Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a SumEvt function #188

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add a SumEvt function #188

wants to merge 1 commit into from

Conversation

silkenelson
Copy link
Collaborator

when we only want the calculation for the ROI having a specific function avoids a potentially wasteful copy operation needed for chaining functions.
This is a best we can easily do for https://jira.slac.stanford.edu/browse/ECS-4440

…avoids a potentially wasteful copy operation needed for chaining functions)
@vespos
Copy link
Collaborator

vespos commented Feb 9, 2024

I think it would be better to sub-class the existing ROIFunc and only rewrite the process method. This way we dont duplicate the setFromDet and applyROI, and in case we need to change them (unlikely) we only have to do it in one spot.
We could also make sure that no one tries to add functions by overwriting the addFunc method with smth like:

def addFunc(...)
    NotImplementedError('This function should not be used with any other DetObjectFunc')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants