Signal cleanup #99
Signal cleanup #99
Conversation
| @@ -66,7 +66,7 @@ def update_title(filename): | |||
| title = 'AMI Client' | |||
| if hutch: | |||
| title += f' hutch: {hutch}' | |||
| if filename: | |||
| if filename is not None: | |||
There was a problem hiding this comment.
This is unrelated, but something that I noticed randomly. If you click new and then save it will save a chart as just '.fc'.
| @@ -230,9 +231,13 @@ def display(self, msg): | |||
| self.win.setCentralWidget(scrollarea) | |||
|
|
|||
| if msg.state and hasattr(self.widget, 'restoreState'): | |||
| self.widget.blockSignals(True) | |||
There was a problem hiding this comment.
If we do not block signals on the widget we cause a checkpoint to be emitted when restoring the state, which is unnecessary.
|
|
||
| self.node.sigStateChanged.connect(self.send_checkpoint) | ||
| if not self.connected: | ||
| self.node.sigStateChanged.connect(self.send_checkpoint) |
There was a problem hiding this comment.
We are connecting the sigStateChanged signal multiple times. Whenever you close the window and reopen it we reconnect which causes N checkpoints to be sent each time you change the widget.
|
I broke something in this pull request. |
|
Actually I guess I havent pushed those changes yet, the pull request as it is, is ok. |
| @@ -633,7 +633,7 @@ def __init__(self, name): | |||
|
|
|||
| def display(self, topics, terms, addr, win, **kwargs): | |||
| if self.widget is None: | |||
| self.widget = FilterWidget(terms, self.output_vars(), win) | |||
| self.widget = FilterWidget(terms or self.input_vars(), self.output_vars(), win) | |||
There was a problem hiding this comment.
This is the fix for the filter. The state is getting out of sync between the flowchart and the subprocess. The subprocess calls display with all the arguments as none, but the subprocess has them filled in, which causes the inconsistency in state.
Maybe a better fix would be to call display with the terms argument in build_views.
Trying to track down #83 this fixes two related issues but still does not solve the problem yet.