Skip to content

Commit

Permalink
✨ Add variable for minimum TLS version (#40)
Browse files Browse the repository at this point in the history
* ✨ Add variable for minimum TLS version

* Use more descriptive variable name
  • Loading branch information
jerr0328 authored Jun 2, 2020
1 parent ec3fc23 commit 7adc3e8
Show file tree
Hide file tree
Showing 5 changed files with 20 additions and 2 deletions.
6 changes: 6 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,9 @@ See the [Terraform Modules documentation](https://www.terraform.io/docs/modules/
Read [pricing page](https://aws.amazon.com/cloudfront/pricing/) for more details.
Options: `PriceClass_100` | `PriceClass_200` | `PriceClass_All`. Default value = `PriceClass_200`
* `ipv6`: (Optional) Enable IPv6 support on CloudFront distribution. Default value = `false`
* `minimum_client_tls_protocol_version`: (Optional) Set the minimum protocol version of the CloudFront certificate.
Read the docs on [Supported Protocols and Ciphers](https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/secure-connections-supported-viewer-protocols-ciphers.html#secure-connections-supported-ciphers)
for supported values. Default value = `TLSv1`

### Outputs

Expand Down Expand Up @@ -144,6 +147,9 @@ See the [Terraform Modules documentation](https://www.terraform.io/docs/modules/
Read [pricing page](https://aws.amazon.com/cloudfront/pricing/) for more details.
Options: `PriceClass_100` | `PriceClass_200` | `PriceClass_All`. Default value = `PriceClass_200`
* `ipv6`: (Optional) Enable IPv6 support on CloudFront distribution. Default value = `false`
* `minimum_client_tls_protocol_version`: (Optional) Set the minimum protocol version of the CloudFront certificate.
Read the docs on [Supported Protocols and Ciphers](https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/secure-connections-supported-viewer-protocols-ciphers.html#secure-connections-supported-ciphers)
for supported values. Default value = `TLSv1`

### Outputs

Expand Down
2 changes: 1 addition & 1 deletion site-main/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ resource "aws_cloudfront_distribution" "website_cdn" {
viewer_certificate {
acm_certificate_arn = var.acm-certificate-arn
ssl_support_method = "sni-only"
minimum_protocol_version = "TLSv1"
minimum_protocol_version = var.minimum_client_tls_protocol_version
}

aliases = [var.domain]
Expand Down
6 changes: 6 additions & 0 deletions site-main/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -71,3 +71,9 @@ variable "ipv6" {
description = "Enable IPv6 on CloudFront distribution"
default = false
}

variable "minimum_client_tls_protocol_version" {
type = string
description = "CloudFront viewer certificate minimum protocol version"
default = "TLSv1"
}
2 changes: 1 addition & 1 deletion site-redirect/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ resource "aws_cloudfront_distribution" "website_cdn" {
viewer_certificate {
acm_certificate_arn = var.acm-certificate-arn
ssl_support_method = "sni-only"
minimum_protocol_version = "TLSv1"
minimum_protocol_version = var.minimum_client_tls_protocol_version
}

aliases = [var.domain]
Expand Down
6 changes: 6 additions & 0 deletions site-redirect/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -46,3 +46,9 @@ variable "default_root_object" {
description = "CloudFront default root object"
default = "index.html"
}

variable "minimum_client_tls_protocol_version" {
type = string
description = "CloudFront viewer certificate minimum protocol version"
default = "TLSv1"
}

0 comments on commit 7adc3e8

Please sign in to comment.