Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto triggering and forced photometry improvements #265

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Auto triggering and forced photometry improvements #265

merged 2 commits into from
Dec 19, 2023

Conversation

Theodlz
Copy link
Collaborator

@Theodlz Theodlz commented Dec 19, 2023

  • auto-triggering handles existing requests in a better way, able to deduplicate better based on different observation_types (and observation_choices) from the requests' payloads.
  • we noticed in prod that forced photometry from IPAC included some duplicate entries. These changes implement a more fool proof logic to avoid concurrency issues when updating an object's fp_hists entry.

@Theodlz Theodlz requested a review from mcoughlin December 19, 2023 00:12
@Theodlz
Copy link
Collaborator Author

Theodlz commented Dec 19, 2023

@nabeelre

mcoughlin
mcoughlin approved these changes Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@mcoughlin mcoughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

kowalski/alert_brokers/alert_broker_ztf.py Show resolved Hide resolved
kowalski/utils.py Show resolved Hide resolved
@Theodlz Theodlz merged commit 4763e77 into skyportal:main Dec 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcoughlin mcoughlin mcoughlin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Theodlz @mcoughlin