Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[k8s] Show enabled contexts in sky check #4587

Merged
merged 2 commits into from
Jan 23, 2025
Merged

[k8s] Show enabled contexts in sky check #4587

merged 2 commits into from
Jan 23, 2025

Conversation

romilbhardwaj
Copy link
Collaborator

Closes #4570.

Some examples:

WIthout allowed_contexts set

image

With allowed_contexts set

image

Running in-cluster auth

image

Running in-cluster auth without SKYPILOT_IN_CLUSTER_CONTEXT_NAME set:

image

@romilbhardwaj romilbhardwaj force-pushed the k8s-show-enabled-contexts branch from f638f1b to ed5870b Compare January 18, 2025 00:02
Michaelvll
Michaelvll approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @romilbhardwaj! LGTM.

sky/check.py Outdated Show resolved Hide resolved
sky/check.py Show resolved Hide resolved
@romilbhardwaj romilbhardwaj merged commit 763e963 into master Jan 23, 2025
18 checks passed
@romilbhardwaj romilbhardwaj deleted the k8s-show-enabled-contexts branch January 23, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Michaelvll Michaelvll Michaelvll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[k8s] Show enabled contexts (allowed_contexts) after sky check
2 participants
@romilbhardwaj @Michaelvll