-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SKY-1304] AWS throws InvalidGroup.Duplicate
when user submits a lot of parallel launch
#4584
Conversation
/quicktest-core |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @weih1121 for fixing this! LGTM. Left some nits.
/smoke-test aws |
/smoke-test aws |
@cblmemo refactor to make it cleaner, it'd be better if you can help review again thanks~ |
/smoke-test aws |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM. I took a quick look and seems like there are only one smoke test failed. Could you double check it is irrelevant to this PR (e.g. also failed on master) and maybe submit an issue for this? After that it should be ready to go!
cc @Michaelvll to double check here.
Thanks @weih1121 again for contributing to skypilot! Looks great to me ;) merging now! |
Fix SKY 1304
Fixes #4578
Root cause:
Solution:
InvalidGroup.Duplicate
exception occurs during security groups creating, query security again and return the created else raise created but not found exception.Test:
Tested (run the relevant ones):
bash format.sh
pytest tests/test_smoke.py
pytest tests/test_smoke.py::test_fill_in_the_name
conda deactivate; bash -i tests/backward_compatibility_tests.sh