-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preliminary Vast AI support #4365
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing to this @kristopolous ! This is really exciting. Left some discussions. One main confusion I have is that, does vast ai like runpod, a cloud providing pods to users as their "VM"s? Asking because I'm seeing a lot of docker related code, and just want to confirm :)
historically, runpod was a clone of vast. We currently offer docker-style containers and will be providing vms soonish (probably before end of year) |
e9e922a
to
4c9aff9
Compare
these test passing is blocked by https://github.com/skypilot-org/skypilot-catalog/pull/100/commits |
2b3e658
to
25b99f9
Compare
Co-authored-by: Tian Xia <[email protected]>
Co-authored-by: Tian Xia <[email protected]>
Co-authored-by: Tian Xia <[email protected]>
Co-authored-by: Tian Xia <[email protected]>
3010706
to
7face5e
Compare
so most of these are ok now ... i've done a number of fixes to the tests in general ... I can send you my logs but that's just "works on my machine" stuff ... so let my communicate how I'm running these: 10:25 /home/chris/code/skypilot$ source env/bin/activate
(env) 10:25 /home/chris/code/skypilot$ pip3 install -e .
(env) 10:25 /home/chris/code/skypilot$ pytest -v -n 1 tests/test_smoke.py --vast if we can agree this is sensible, all the tests you asked for should be passing |
Seems like there are still some CI test failing ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this @kristopolous ! It mostly looks good to me. Left final nits ;)
/smoke-test aws |
Seems like the smoke test on AWS passed as well. After resolving those final nits it should be ready to go! |
6fc6a2b
to
f83d114
Compare
ded6e83
to
8280216
Compare
pytest -v -n 1 tests/test_optimizer_random_dag.py --vast This test passes. Is there anything else we need? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing @kristopolous ! Left one final nits. Could you also help resolve the merge conflicts?
Seems like the CI is failing because the catalog is missing. I just merged the catalog PR and I'm running the tests one last time. If it passed then this should be ready to go!
/smoke-test aws |
Seems like the https://github.com/skypilot-org/skypilot/actions/runs/12971661591/job/36178313189?pr=4365 |
This is preliminary support for Vast. It currently works on an unreleased version of the SDK which we will soon get up to PyPy
The document https://docs.google.com/document/d/1oWox3qb3Kz3wXXSGg9ZJWwijoa99a3PIQUHBR8UgEGs/edit?pli=1&tab=t.0 was followed and all the testing passed
Tested (run the relevant ones):
bash format.sh
pytest tests/test_smoke.py
pytest tests/test_smoke.py::test_fill_in_the_name
conda deactivate; bash -i tests/backward_compatibility_tests.sh
I'm pretty sure there will need to be edits, I'm fine with that. This is attempt 1. The outstanding work:
We need to