Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Refactored PlanetsLayer #295

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Refactored PlanetsLayer #295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions app/src/main/java/com/google/android/stardroid/layers/PlanetsLayer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,8 @@ protected void initializeAstroSources(ArrayList<AstronomicalSource> sources) {
sources.add(new PlanetSource(planet, getResources(), model, preferences));
}
}

// TODO(brent): Remove this.
@Override
// If the preference Id is needed. There is no super method and no need
// to override.
public String getPreferenceId() {
return "source_provider.3";
}
Expand All @@ -63,6 +62,6 @@ public int getLayerDepthOrder() {

@Override
protected int getLayerNameId() {
return R.string.show_planets_pref; // TODO(johntaylor): rename the string id.
return R.string.solar_system;
}
}
2 changes: 1 addition & 1 deletion app/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
<string name="show_stars_pref">Stars</string>
<string name="show_constellations_pref">Constellations</string>
<string name="show_messier_objects_pref" translation_description="The celestial objects catalogued by Charles Messier">Messier Objects</string>
<string name="show_planets_pref">Solar System</string>
<string name="solar_system">Solar System</string>
<string name="show_grid_pref">RA/Dec Grid</string>
<string name="show_horizon_pref">Horizon</string>
<string name="show_sky_gradient" translation_description="This is a shading of the color of the sky used for effect">Sky Gradient</string>
Expand Down