Changes in search control bar

[sashrikakaur]

Signed-off-by: Sashrika Kaur [email protected]

Fixes #252

The cancel search button was overlapping with the sky map toolbar. Adding a margin prevents the overlap and allows easy access of the menu in skymap toolbar and search button in the search control bar.

[tavishjain]

This is a really bad implementation of how you have fixed the code. Simply giving a padding to the app bar doesn't completely fix this issue

[jaydeetay]

Thanks for the fix @sashrikakaur . It looks like there's a conflict in gradle.xml - can you remove that file from the PR? We have a separate task add this file to .gitignore.

@tavishjain can you explain your objections a little more? At first glance this looks like a reasonable fix.

[tavishjain]

@jaydeetay this shifting of the app bar is not the exact fix for this issue. We will have to use CoordinatorLayout so that on press on the screen, the app bar moves down and on tapping again, it moves back up

[jaydeetay]

We certainly could do that. It's not obvious to me why having the search controls stay in the same spot would be inherently bad though.

…

On Sat, 30 Mar 2019 at 12:56 Tavish Jain ***@***.***> wrote: @jaydeetay <https://github.com/jaydeetay> this shifting of the app bar is not the exact fix for this issue. We will have to use CoordinatorLayout so that on press on the screen, the app bar moves down and on tapping again, it moves back up — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#259 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/APq7CytBryyLdXa_kcDcfrqF-jglLNUDks5vb5ckgaJpZM4cTWhe> .

[tavishjain]

@jaydeetay it is not bad that the search controls remain in the same place, but it provides a bad UX. Having a free space abbove the app bar (the one in Red colour) doesnt reallly seem to be good.

[sashrikakaur]

Considering sky map uses OpenGL ES to render views adding a padding doesn't necessarily mean a bad UI as the whole view is used in the app to display celestial objects and so does the space above the screen.
Hence, I think this would be a good fix as the space present is not empty it still renders a view.
Let me know if you have an alternate solution @jaydeetay @tavishjain , I'll be happy to hear your implementation for the same!

[sashrikakaur]

@jaydeetay , I've resolved the conflict, let me know if everything looks good now.

[sashrikakaur]

closed in favor of #264