migrate to Bazel 8 using bzlmod #528
Open
+16
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turns out to be trivial, no changes needed other than adding a MODULE.bazel file with a bazel_dep for skylib, and deletion of the WORKSPACE file.
If you want to support previous versions of Bazel you'd have to tell the user to use
--enable_bzlmodor some such.BTW thanks for making this available. I've been using version 2.0.3 for a few years, it's pretty amazing. I've been building it with Bazel and rules_foreign_cc, which usually took over a minute to compile. WIth the latest version and Bazel it take seconds. Yay!