Process flows more efficiency in network observer #1940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-kruse
force-pushed
the
collector-flow-cache-iterator
branch
from
e10fd57 to
ad7c61a
Compare
|
Example resource usage for the latest Memory usage -25% CPU usage - much better. |
c-kruse
force-pushed
the
collector-flow-cache-iterator
branch
from
ad7c61a to
ef45b13
Compare
The network observer handles an in memory buffer of application and transport level flow records and associated state that can be very large. This changes how those collections are traversed for processing. Previously the collections of flow state were copied on each reconcile loop, resulting in high CPU and memory utilization. Now each reconcile job limits itself to copying the relevant portions by using an iterator and filters. Signed-off-by: Christian Kruse <[email protected]>
c-kruse
force-pushed
the
collector-flow-cache-iterator
branch
2 times, most recently
from
6018751 to
9887401
Compare
Signed-off-by: Christian Kruse <[email protected]>
c-kruse
force-pushed
the
collector-flow-cache-iterator
branch
from
9887401 to
7c88cc3
Compare
fgiorgetti
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The network observer handles an in memory buffer of application and transport level flow records and associated state that can be very large. This fix reorganizes the data structure that contains flow state and the reconcile tasks that operate on that state in order to avoid reallocating and copying the full collection on each iteration. Fixes #1942 by greatly reducing CPU cycles spent copying data structures and doing garbage collection.