-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated rootful namespace home to var lib #1749
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes themselves look good for me, but I think there is a couple of pre-existing documentation mistakes that could be looked into.
cmd/bootstrap/README.md
Outdated
@@ -68,7 +68,7 @@ the runtime files generated during initialization. | |||
Namespaces are stored under ${XDG_DATA_HOME}/.local/share/skupper/namespaces |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be ${XDG_DATA_HOME}/skupper/namespaces
, instead (ie, without .local/share
, which is part of the default ${XDG_DATA_HOME}
).
https://specifications.freedesktop.org/basedir-spec/latest/
$XDG_DATA_HOME defines the base directory relative to which user-specific data files should be stored. If $XDG_DATA_HOME is either not set or empty, a default equal to $HOME/.local/share should be used.
cmd/bootstrap/bootstrap.go
Outdated
@@ -46,7 +46,7 @@ the runtime files generated during initialization. | |||
Namespaces are stored under ${XDG_DATA_HOME}/.local/share/skupper/namespaces |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here: ${XDG_DATA_HOME}/skupper/namespaces
, instead.
@fgiorgetti the Path Provider methods should be updated as well or they should be replaced? |
@nluaces In PR #1713 , @lynnemorrison already modified the Path Provider to use |
* Only rootful namespace home has been updated to /var/lib * Rootless remain as is assuming that XDG_DATA_HOME seems to be appropriate (see: https://specifications.freedesktop.org/basedir-spec/latest/) Fixes skupperproject#1689
(see: https://specifications.freedesktop.org/basedir-spec/latest/)
Fixes #1689