Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Erlang Distribution #518

Merged
merged 4 commits into from
Jan 24, 2025
Merged

[ENH] Erlang Distribution #518

merged 4 commits into from
Jan 24, 2025

Conversation

RUPESH-KUMAR01
Copy link
Contributor

@RUPESH-KUMAR01 RUPESH-KUMAR01 commented Jan 17, 2025

Reference Issues/PRs

Implementing a distribution towards #22

What does this implement/fix? Explain your changes.

Implements Erlang Distribution

Does your contribution introduce a new dependency? If yes, which one?

No

What should a reviewer concentrate their feedback on?

Sorry for the issue on Previous PR #517 .

PR checklist

For all contributions
  • I've added myself to the list of contributors with any new badges I've earned :-)
    How to: add yourself to the all-contributors file in the skpro root directory (not the CONTRIBUTORS.md). Common badges: code - fixing a bug, or adding code logic. doc - writing or improving documentation or docstrings. bug - reporting or diagnosing a bug (get this plus code if you also fixed the bug in the PR).maintenance - CI, test framework, release.
    See here for full badge reference
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings.
For new estimators
  • I've added the estimator to the API reference - in docs/source/api_reference/taskname.rst, follow the pattern.
  • I've added one or more illustrative usage examples to the docstring, in a pydocstyle compliant Examples section.
  • If the estimator relies on a soft dependency, I've set the python_dependencies tag and ensured
    dependency isolation, see the estimator dependencies guide.

@fkiraly
Copy link
Collaborator

fkiraly commented Jan 18, 2025

Sorry for the issue on Previous PR #517 .

No problem - I did not think there was a major issue - if you post in dev-chat, we could have surely figured it out.

Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fkiraly fkiraly added enhancement module:probability&simulation probability distributions and simulators labels Jan 19, 2025
Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found the issue - shape was a reserved parameter.

I added some info in the extension template to avoid this issue in the future: #521

@fkiraly fkiraly merged commit af584ad into sktime:main Jan 24, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement module:probability&simulation probability distributions and simulators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants