-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] concat
operation on distributions
#499
base: main
Are you sure you want to change the base?
Conversation
changed it to draft, until it is not finished |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Pattern looks good.
I assume this is work in progress, so some comments:
- the
__init__
may need to have anindex
andcolumns
argument. - implementing
mean
etc is the old, deprecated extension pattern. Now you need to implement_mean
etc, seeextension_templates/distributions
. - there are more methods to implement, and
get_test_params
should be set.
I made some changes to fix the delegation - but it is currently missing treatment of the indices. I think what should happen in
Until this is resolved, |
Reference Issues/PRs
#340What does this implement/fix? Explain your changes.
Implements the concat operation on distributions.See #340 (comment)
PR checklist
For all contributions
How to: add yourself to the all-contributors file in the
skpro
root directory (not theCONTRIBUTORS.md
). Common badges:code
- fixing a bug, or adding code logic.doc
- writing or improving documentation or docstrings.bug
- reporting or diagnosing a bug (get this pluscode
if you also fixed the bug in the PR).maintenance
- CI, test framework, release.See here for full badge reference