feat: support the necessary configurability for testing odh-nightly builds #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kornys
approved these changes
Jun 27, 2024
Frawless
approved these changes
Jun 27, 2024
…uilds The expected settings for running odh-nightly build, which is ODH packaged as if it was RHOAI, are something like ``` PRODUCT=odh DEFAULT_DSCI_NAME=default-dsci OPERATOR_INSTALL_TYPE=olm OLM_SOURCE_NAME=rhoai-source OLM_OPERATOR_NAME=rhods-operator OLM_OPERATOR_CHANNEL=odh-nightlies OLM_SOURCE_NAMESPACE=openshift-marketplace OLM_OPERATOR_VERSION=1.18.0 ``` * fixup, undo mistaken line before I realized I need to set this in `Environment`
jiridanek
force-pushed
the
jd_odh_nightly
branch
from
ba7d806 to
96557ff
Compare
jiridanek
added a commit
to jiridanek/odh-e2e
that referenced
this pull request
Jul 19, 2024
…ate that if it already exists This is a followup to skodjob#148 where I missed this.
jiridanek
added a commit
to jiridanek/odh-e2e
that referenced
this pull request
Jul 19, 2024
…ate that if it already exists This is a followup to skodjob#148 where I missed this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't fully try this because operator in odh-nightlies gets stuck after deleting dsci, but these should be all the changes necessary.
The expected settings for running odh-nightly build, which is ODH packaged as if it was RHOAI, are something like