Add SEO_JS_PRERENDER_TIMEOUT functionality #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great. I'm pretty slammed right now, but will get it merged in once I get some free cycles! Thanks for contributing! |
|
Update - things are moving forward without me being in the way. Please see #32 for our next steps in this project, and thank you so much for your contributions, and for your patience. :) |
|
@clifff can you update your PR? I think this is the nice thing we can get included into the next release. |
|
@bmwant - I haven't been using Django or even Python in a number of years so I'm not inclined to sort through rebasing, but happy to accept any updates to this PR or I can close it if someone else would like to re-implement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been seeing some very slow interactions with prerender.io (up to 59 seconds) in New Relic recently, so I wanted to add a timeout option to prevent the application server from being tied up for that long. In the case that the timeout is hit, a 408 response is returned, so the seo bot should try again later and hopefully have better luck.