Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Farsi translation update #660

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Farsi translation update #660

wants to merge 11 commits into from

Conversation

AmizRm
Copy link
Contributor

@AmizRm AmizRm commented Oct 8, 2024

Summary by CodeRabbit

  • Bug Fixes
    • Corrected punctuation and formatting in localization strings for improved readability.
    • Adjusted spacing and hyphenation in various phrases to enhance display in the user interface.

Copy link

coderabbitai bot commented Dec 8, 2024

✅ Actions performed

Full review triggered.

Copy link

coderabbitai bot commented Dec 8, 2024

Walkthrough

The changes involve updates to the sklmessages_fa_IR.properties file, which contains localization strings for a launcher application in Persian. The modifications focus on correcting punctuation, formatting, and spacing issues to enhance the display and readability of the text in the user interface. Specific adjustments include the addition of non-breaking spaces and hyphens in various strings, particularly in sections related to crash reporting and settings, as well as standardizing punctuation in alert messages.

Changes

File Path Change Summary
assets/launcher/lang/sklmessages_fa_IR.properties Corrections to punctuation, spacing, and hyphenation; added non-breaking spaces and standardized formatting in crash reporting, settings, and alert messages.

Poem

In the land of code where bunnies play,
Strings were polished, brightened the day.
With spaces and hyphens, all neat and clear,
Our launcher now sings, bringing users near.
Hopping with joy, we celebrate this feat,
For clarity in text makes our work sweet! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 2217496 and c5b940a.

📒 Files selected for processing (1)
  • assets/launcher/lang/sklmessages_fa_IR.properties (5 hunks)
🔇 Additional comments (6)
assets/launcher/lang/sklmessages_fa_IR.properties (6)

58-60: LGTM! Improved readability with proper Persian formatting

The changes correctly implement Persian writing conventions with proper spacing and punctuation while maintaining accurate technical translations.


90-90: LGTM! Consistent terminology in settings translations

The translations maintain consistency in technical terminology while following Persian language conventions. The sorting options and settings headers are properly localized with clear meaning.

Also applies to: 94-94, 101-104, 110-110, 113-114


119-124: LGTM! Consistent resource type translations

The translations maintain consistency across different resource types with proper Persian plural forms and technical terminology.


143-143: LGTM! Accurate technical translations

Technical terms and warnings are accurately translated while maintaining their technical meaning. The JVM-related terms and compatibility warnings are properly contextualized in Persian.

Also applies to: 153-153, 158-158, 161-162


163-164: LGTM! Clear and consistent UI translations

Search functionality and error states are clearly translated while maintaining consistency with the UI context.


178-183: LGTM! Clear and accurate warning messages

Critical warnings and technical explanations are accurately translated with proper Persian formatting. The messages effectively convey the severity and technical details of the warnings.

Also applies to: 187-190


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant