Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(fe): update playwright config and add some tests #2355

Merged
merged 5 commits into from
Feb 6, 2025
Merged

chore(fe): update playwright config and add some tests #2355

merged 5 commits into from
Feb 6, 2025

Conversation

eunnbi
Copy link
Contributor

@eunnbi eunnbi commented Feb 5, 2025 •
edited
Loading

Description

  • auth setup 테스트 추가 (user, admin)
  • 인증되지 않은 유저에 대한 테스트 예시 추가

로컬 서버 느려서 테스트 한꺼번에 돌리면 실패하더라고요
pnpm test:e2e --ui 실행해 하나씩 테스트한 결과입니다

image image

Additional context

Before submitting the PR, please make sure you do the following

@eunnbi eunnbi self-assigned this Feb 5, 2025
@eunnbi eunnbi requested review from Kohminchae and B0XERCAT February 6, 2025 05:08
@eunnbi eunnbi marked this pull request as ready for review February 6, 2025 05:08
B0XERCAT
B0XERCAT approved these changes Feb 6, 2025
View reviewed changes
Copy link
Member

@B0XERCAT B0XERCAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
AuthProvider도 나이스합니다

@eunnbi eunnbi merged commit 426b8c8 into main Feb 6, 2025
16 checks passed
@eunnbi eunnbi deleted the test/e2e-setup branch February 6, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@B0XERCAT B0XERCAT B0XERCAT approved these changes

@Kohminchae Kohminchae Kohminchae approved these changes

Assignees

@eunnbi eunnbi

Labels
⛳️ team-frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eunnbi @Kohminchae @B0XERCAT