-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
widget: add support for taddrs on penumbra #759
widget: add support for taddrs on penumbra #759
Conversation
|
@erwanor is attempting to deploy a commit to the Skip Protocol Team on Vercel. A member of the Team first needs to authorize it. |
@NotJeremyLiu to test end-to-end with local API |
@NotJeremyLiu opened #770, if you test this PR you will learn that the current address validation in the client packages does not handle Penumbra. Hopefully this saves some time, happy to test things here with you if that's helpful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll pass sourceChainID
after merge, I test this flow works fine. Thanks
37ecb2e
into
skip-mev:penumbra-address-fixes
This PR:
I wasn't able to test the PR end-to-end, because trying to generate a route leads me to this error:
Which I couldn't trace the source of. I think this might coming from the solver backend directly? unsure. If you tell me where to look I should be able to test this.