Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 [API-2527] Correct Cw20 Swap Calldata on Astroport and WhiteWhale #91

Merged
merged 8 commits into from
Feb 19, 2024
Merged

🐛 [API-2527] Correct Cw20 Swap Calldata on Astroport and WhiteWhale #91

merged 8 commits into from
Feb 19, 2024

Conversation

NotJeremyLiu
Copy link
Member

@NotJeremyLiu NotJeremyLiu commented Feb 14, 2024 •
edited
Loading

Background

  • We had a PR previously that changed swaps to no longer use the router. When this change was made, cw20 swaps broke due to incorrect call data.
  • This PR fixes that by providing the correct types/calldata for cw20 swaps on both Astroport and WhiteWhale

@NotJeremyLiu NotJeremyLiu changed the title 🐛 [API-2527] Correct Cw20 Swaps Calldata on Astroport and White Whale 🐛 [API-2527] Correct Cw20 Swap Calldata on Astroport and WhiteWhale Feb 14, 2024
@NotJeremyLiu NotJeremyLiu requested a review from thal0x February 14, 2024 19:11
@NotJeremyLiu NotJeremyLiu marked this pull request as ready for review February 14, 2024 19:12
@NotJeremyLiu NotJeremyLiu merged commit 7662d8a into main Feb 19, 2024
5 checks passed
@NotJeremyLiu NotJeremyLiu deleted the jl/fix-cw20-swaps branch February 19, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thal0x thal0x thal0x approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NotJeremyLiu @thal0x