✨ Implement White Whale swap adapter #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- avoids needing to update if future swap adapters needs one off execute methods
NotJeremyLiu
reviewed
Feb 6, 2024
NotJeremyLiu
changed the title
- all fees are taken from the out asset - since all ww pools that are live right now are constant product, we could just do out/in asset ratios to get spot price. This may break down as new pool types are introduced. Keeping this amount-based logic in for now
NotJeremyLiu
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the White Whale swap adapter contract which is essentially the same as the Astroport one with some very minor type differences.