-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [API-1723] Add CW20 Support #67
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also runs make update and make upgrade
… swap and action call
- No changes made to the ExecuteMsg::Swap since Osmosis does not support cw-20 tokens
- now tested in test_execite_swap_and_action.rs
- must switch info.sender after the sent_asset is created
- broadcast_tx_commit was not meant to be used in prod
zrbecker
approved these changes
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This PR
This PR adds support for CW20 tokens:
How to Review
Interface Breaking Changes
min_coin
param (type: Coin) sent with the swap_and_action entry point contract calls has been changed to amin_asset
param (type: Asset).Rust types:
Json format of native coin:
Json format of cw20 token:
PostSwapAction::BankSend
enum variant has been changed toPostSwapAction::Transfer
to be inclusive of both coins and cw20 token transfers.sent_asset
param, where the caller must specify what asset they sent to the contract (which gets validated).