[API-2954] Drop - Do not simulate getting out of bonded denom #130
+115
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bonded denom, not the other way around for SwapExactIn queries, only allow for users to simulate swaps starting from the remote denom and going to the bonded denom. for SwapExactOut queries, only allow for users to simulate getting the bonded denom out, meaning they would be starting from the remote denom for the swap
mattac21
changed the title
mattac21
commented
Aug 12, 2024
| match denom_in { | ||
| // if doing an 'in' query, only allow for simulating putting the remote denom in | ||
| denom_in if denom_in == remote_denom => Ok(bonded_denom.to_string()), | ||
| denom_in if denom_in == bonded_denom => Err(ContractError::UnsupportedDenom), |
There was a problem hiding this comment.
if they're trying to simulate a swap where the input is the bonded denom, fail
mattac21
commented
Aug 12, 2024
| match denom_out { | ||
| // if doing an 'out' query, only allow for simulating getting the bonded denom out | ||
| denom_out if denom_out == remote_denom => Err(ContractError::UnsupportedDenom), | ||
| denom_out if denom_out == bonded_denom => Ok(remote_denom.to_string()), |
There was a problem hiding this comment.
if they're trying to simulate a swap where where the output would be the remote denom (i.e. swapping the bonded denom to the remote denom), fail
NotJeremyLiu
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
SimulateSwapExactAssetInsimulations, do not allow for simulations where theAssetInis thebonded_denom. ForSimulateSwapExactAssetOutsimulations, do not allow for simulations where theAssetOutis theremote_denom.