Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emit amount out of swap #110

Merged
merged 2 commits into from
May 8, 2024
Merged

emit amount out of swap #110

merged 2 commits into from
May 8, 2024

Conversation

thal0x
Copy link
Member

@thal0x thal0x commented May 8, 2024

Emits the amount received from swaps

closes #95

@thal0x thal0x self-assigned this May 8, 2024
@@ -524,6 +524,10 @@ pub fn execute_post_swap_action(
transfer_out_asset
};

response = response
.add_attribute("amount_out", transfer_out_asset.amount().to_string())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's make this name a little more unique for easier searching, maybe "post_swap_action_amount_out" and "post_swap_action_denom_out"

Copy link
Member

@NotJeremyLiu NotJeremyLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a comment to make the names more specific, down to merge after change

@thal0x thal0x merged commit c8f8ec2 into main May 8, 2024
5 checks passed
@thal0x thal0x deleted the jw/emit-amount-out branch May 8, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: Swap output amount event
2 participants