Support split routes in entry point contract #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotJeremyLiu
approved these changes
Apr 29, 2024
contracts/entry-point/src/execute.rs
Outdated
| .enumerate() | ||
| .max_by_key(|(_, route)| route.offer_asset.amount()) | ||
| .map(|(idx, _)| idx) | ||
| .unwrap() |
There was a problem hiding this comment.
How does the handle routes with the same amount in? Is it first route or does it error be if there's a tie?
Also using unwrap in general is a practice that should be avoided / used in tests but not prod code if can be caught and given a useful error instead
contracts/entry-point/src/execute.rs
Outdated
| @@ -646,3 +686,26 @@ fn query_swap_asset_in( | |||
|
|
|||
| Ok(fee_swap_asset_in) | |||
| } | |||
|
|
|||
| // fn get_largest_route_idx(routes: Vec<Route>) -> usize { | |||
| &deps, | ||
| fee_swap, | ||
| &mut remaining_asset, | ||
| &ibc_fee_coin, | ||
| )?; | ||
|
|
||
| // Update the user swap to deduct the ibc fee amount from the route | ||
| // with the largest input amount | ||
| user_swap = match user_swap.clone() { |
There was a problem hiding this comment.
This logic makes sense to me, it just has to match with what the server does
thal0x
added a commit
that referenced
this pull request
May 7, 2024
* Revert "Add split route support in all adapters (#103)" This reverts commit 1fa4f21. * Revert "Support multiple routes in astroport adapter (#99)" This reverts commit a95f17d. * Revert "Support split routes in entry point contract (#101)" This reverts commit 94c3bbf. * Revert "Update contract types to support route splitting (#98)" This reverts commit ec1fd57. * Revert "add interface field to SwapOperation (#96)" This reverts commit eb37618.
thal0x
added a commit
that referenced
this pull request
May 8, 2024
* add SmartSwapExactAssetIn swap type * Revert "Add split route support in all adapters (#103)" This reverts commit 1fa4f21. * Revert "Support multiple routes in astroport adapter (#99)" This reverts commit a95f17d. * Revert "Support split routes in entry point contract (#101)" This reverts commit 94c3bbf. * Revert "Update contract types to support route splitting (#98)" This reverts commit ec1fd57. * Revert "add interface field to SwapOperation (#96)" This reverts commit eb37618. * remove deployed test contracts * fix fmt issue * update schema * since user_swap is mutatable, we can mutate in place * swap excess funds * update schema * lint change * fix test * add optional interface field to SwapOperation (#108) * return error for largest_route_index --------- Co-authored-by: Jeremy Liu <[email protected]>
thal0x
added a commit
that referenced
this pull request
May 8, 2024
* add SmartSwapExactAssetIn swap type * Revert "Add split route support in all adapters (#103)" This reverts commit 1fa4f21. * Revert "Support multiple routes in astroport adapter (#99)" This reverts commit a95f17d. * Revert "Support split routes in entry point contract (#101)" This reverts commit 94c3bbf. * Revert "Update contract types to support route splitting (#98)" This reverts commit ec1fd57. * Revert "add interface field to SwapOperation (#96)" This reverts commit eb37618. * remove deployed test contracts * fix fmt issue * update schema * since user_swap is mutatable, we can mutate in place * swap excess funds * update schema * lint change * fix test * add optional interface field to SwapOperation (#108) * return error for largest_route_index * [API-2792] Add hallswap adapter (#102) * feat: add hallswap adapter * chore: add readme * pr fixes * add optional interface field to SwapOperation * update hallswap adapter to implement updated interface * remove get_hallswap_routes_from_skip_routes --------- Co-authored-by: thal0x <[email protected]> --------- Co-authored-by: Jeremy Liu <[email protected]> Co-authored-by: Yonggiee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the Entry Point contract to support multiple routes when calling
SwapExactAssetIn.SwapExactAssetOutwill continue to be unsupported for the time being due to added complexity and no current integrators supporting this anyways.