fix: don't fail post handler on simulate tx with no fee #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
aljo242
commented
Jun 16, 2024
aljo242
commented
- add similar logic as bug: Don't fail ante handler on simulate tx with no fee #120 in post handler
- additional unit testing
- gas estimation remains the same as it was before this PR from simulating test Tx
aljo242
requested review from
davidterpay,
nivasan1 and
Eric-Warehime
as code owners
added 4 commits
June 16, 2024 08:56
bpiv400
approved these changes
Jun 16, 2024
| @@ -29,14 +29,14 @@ require ( | |||
| github.com/grpc-ecosystem/grpc-gateway v1.16.0 | |||
| github.com/skip-mev/chaintestutil v0.0.0-20240514161515-056d7ba45610 | |||
| github.com/spf13/cast v1.6.0 | |||
| github.com/spf13/cobra v1.8.0 | |||
| github.com/spf13/cobra v1.8.1 | |||
There was a problem hiding this comment.
Is this intentional / relevant? (Feel free to ignore)
Eric-Warehime
approved these changes
Jun 16, 2024
mergify bot
pushed a commit
that referenced
this pull request
Jun 16, 2024
* ok * ok * format * ok * clean readme * retract * mod bump (cherry picked from commit 9a2a3ee) # Conflicts: # go.mod # go.sum # x/feemarket/post/fee.go
aljo242
pushed a commit
that referenced
this pull request
Jun 17, 2024
… (#123) * fix: don't fail post handler on simulate tx with no fee (#122) * ok * ok * format * ok * clean readme * retract * mod bump (cherry picked from commit 9a2a3ee) # Conflicts: # go.mod # go.sum # x/feemarket/post/fee.go * fix --------- Co-authored-by: Alex Johnson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.