lint fix

skip-mev · Jul 2, 2024 · 4810c2c · 4810c2c
1 parent 53649a7
commit 4810c2c
Show file tree

Hide file tree

Showing 13 changed files with 258 additions and 259 deletions.
diff --git a/abci/checktx/mempool_parity_check_tx.go b/abci/checktx/mempool_parity_check_tx.go
@@ -132,7 +132,7 @@ func (m MempoolParityCheckTx) CheckTx() CheckTx {
 			)
 
 			return sdkerrors.ResponseCheckTxWithEvents(
-				fmt.Errorf("tx size exceeds max bytes for lane %s", lane.Name),
+				fmt.Errorf("tx size exceeds max bytes for lane %s", lane.Name()),
 				0,
 				0,
 				nil,
@@ -184,16 +184,6 @@ func (m MempoolParityCheckTx) GetContextForTx(req *cmtabci.RequestCheckTx) sdk.C
 	}
 	ctx, _ := sdk.NewContext(ms, header, true, m.baseApp.Logger()).CacheContext()
 
-	// Set the context to the correct checking mode.
-	switch req.Type {
-	case cmtabci.CheckTxType_New:
-		ctx = ctx.WithIsCheckTx(true)
-	case cmtabci.CheckTxType_Recheck:
-		ctx = ctx.WithIsReCheckTx(true)
-	default:
-		panic("unknown check tx type")
-	}
-
 	// Set the remaining important context values.
 	ctx = ctx.
 		WithTxBytes(req.Tx).

diff --git a/abci/utils_test.go b/abci/utils_test.go
@@ -31,7 +31,7 @@ func (s *ProposalsTestSuite) setUpAnteHandler(expectedExecution map[sdk.Tx]bool)
 		txCache[hashStr] = pass
 	}
 
-	anteHandler := func(ctx sdk.Context, tx sdk.Tx, simulate bool) (newCtx sdk.Context, err error) {
+	anteHandler := func(ctx sdk.Context, tx sdk.Tx, _ bool) (newCtx sdk.Context, err error) {
 		bz, err := s.encodingConfig.TxConfig.TxEncoder()(tx)
 		s.Require().NoError(err)
 

diff --git a/block/base/tx_priority.go b/block/base/tx_priority.go
@@ -9,10 +9,10 @@ import (
 // DefaultTxPriority
 func DefaultTxPriority() TxPriority[int] {
 	return TxPriority[int]{
-		GetTxPriority: func(goCtx context.Context, tx sdk.Tx) int {
+		GetTxPriority: func(_ context.Context, _ sdk.Tx) int {
 			return 0
 		},
-		Compare: func(a, b int) int {
+		Compare: func(_, _ int) int {
 			return 0
 		},
 		MinValue: 0,

diff --git a/block/types.go b/block/types.go
@@ -21,7 +21,7 @@ type (
 // NoOpPrepareLanesHandler returns a no-op prepare lanes handler.
 // This should only be used for testing.
 func NoOpPrepareLanesHandler() PrepareLanesHandler {
-	return func(ctx sdk.Context, proposal proposals.Proposal) (proposals.Proposal, error) {
+	return func(_ sdk.Context, proposal proposals.Proposal) (proposals.Proposal, error) {
 		return proposal, nil
 	}
 }

diff --git a/go.mod b/go.mod
diff --git a/go.sum b/go.sum
diff --git a/lanes/base/abci_test.go b/lanes/base/abci_test.go
@@ -535,7 +535,7 @@ func (s *BaseTestSuite) TestPrepareLane() {
 		)
 		s.Require().NoError(err)
 
-		mh := func(ctx sdk.Context, tx sdk.Tx) bool {
+		mh := func(_ sdk.Context, _ sdk.Tx) bool {
 			return true
 		}
 
@@ -1043,7 +1043,7 @@ func (s *BaseTestSuite) TestProcessLane() {
 		s.Require().NoError(err)
 
 		// First lane matches this lane the other does not.
-		mh := func(ctx sdk.Context, tx sdk.Tx) bool {
+		mh := func(_ sdk.Context, tx sdk.Tx) bool {
 			return tx == tx1
 		}
 
@@ -1301,7 +1301,7 @@ func (s *BaseTestSuite) TestProcessLane() {
 			tx4,
 		}
 
-		mh := func(ctx sdk.Context, tx sdk.Tx) bool {
+		mh := func(_ sdk.Context, tx sdk.Tx) bool {
 			if tx == tx1 || tx == tx2 {
 				return false
 			}
@@ -1387,7 +1387,7 @@ func (s *BaseTestSuite) TestProcessLane() {
 			tx4,
 		}
 
-		mh := func(ctx sdk.Context, tx sdk.Tx) bool {
+		mh := func(_ sdk.Context, _ sdk.Tx) bool {
 			return true
 		}
 
@@ -1462,7 +1462,7 @@ func (s *BaseTestSuite) TestProcessLane() {
 			tx4,
 		}
 
-		mh := func(ctx sdk.Context, tx sdk.Tx) bool {
+		mh := func(_ sdk.Context, tx sdk.Tx) bool {
 			if tx == tx1 || tx == tx3 {
 				return false
 			}
@@ -1680,7 +1680,7 @@ func (s *BaseTestSuite) setUpAnteHandler(expectedExecution map[sdk.Tx]bool) sdk.
 		txCache[hashStr] = pass
 	}
 
-	anteHandler := func(ctx sdk.Context, tx sdk.Tx, simulate bool) (newCtx sdk.Context, err error) {
+	anteHandler := func(ctx sdk.Context, tx sdk.Tx, _ bool) (newCtx sdk.Context, err error) {
 		bz, err := s.encodingConfig.TxConfig.TxEncoder()(tx)
 		s.Require().NoError(err)
 

diff --git a/lanes/free/lane.go b/lanes/free/lane.go
@@ -39,7 +39,7 @@ func NewFreeLane[C comparable](
 // default implementation matches transactions that are staking related. In particular,
 // any transaction that is a MsgDelegate, MsgBeginRedelegate, or MsgCancelUnbondingDelegation.
 func DefaultMatchHandler() base.MatchHandler {
-	return func(ctx sdk.Context, tx sdk.Tx) bool {
+	return func(_ sdk.Context, tx sdk.Tx) bool {
 		for _, msg := range tx.GetMsgs() {
 			switch msg.(type) {
 			case *types.MsgDelegate:

diff --git a/lanes/mev/factory.go b/lanes/mev/factory.go
@@ -111,7 +111,7 @@ func (config *DefaultAuctionFactory) GetTimeoutHeight(tx sdk.Tx) (uint64, error)
 
 // MatchHandler defines a default function that checks if a transaction matches the mev lane.
 func (config *DefaultAuctionFactory) MatchHandler() base.MatchHandler {
-	return func(ctx sdk.Context, tx sdk.Tx) bool {
+	return func(_ sdk.Context, tx sdk.Tx) bool {
 		bidInfo, err := config.GetAuctionBidInfo(tx)
 		return bidInfo != nil && err == nil
 	}

diff --git a/lanes/mev/mempool.go b/lanes/mev/mempool.go
@@ -12,7 +12,7 @@ import (
 // is to be used in the mev index only.
 func TxPriority(config Factory) base.TxPriority[string] {
 	return base.TxPriority[string]{
-		GetTxPriority: func(goCtx context.Context, tx sdk.Tx) string {
+		GetTxPriority: func(_ context.Context, tx sdk.Tx) string {
 			bidInfo, err := config.GetAuctionBidInfo(tx)
 			if err != nil || bidInfo == nil || bidInfo.Bid.IsNil() {
 				return ""

diff --git a/lanes/mev/testutils/testutil.go b/lanes/mev/testutils/testutil.go
@@ -61,7 +61,7 @@ func (s *MEVLaneTestSuiteBase) InitLane(
 	factory := mev.NewDefaultAuctionFactory(s.EncCfg.TxConfig.TxDecoder(), signer_extraction.NewDefaultAdapter())
 	matchHandler := factory.MatchHandler()
 	if matchAll {
-		matchHandler = func(ctx sdk.Context, tx sdk.Tx) bool {
+		matchHandler = func(_ sdk.Context, _ sdk.Tx) bool {
 			return true
 		}
 	}
@@ -80,7 +80,7 @@ func (s *MEVLaneTestSuiteBase) SetUpAnteHandler(expectedExecution map[sdk.Tx]boo
 		txCache[hashStr] = pass
 	}
 
-	anteHandler := func(ctx sdk.Context, tx sdk.Tx, simulate bool) (newCtx sdk.Context, err error) {
+	anteHandler := func(ctx sdk.Context, tx sdk.Tx, _ bool) (newCtx sdk.Context, err error) {
 		bz, err := s.EncCfg.TxConfig.TxEncoder()(tx)
 		s.Require().NoError(err)
 

diff --git a/tests/app/testappd/cmd/testnet.go b/tests/app/testappd/cmd/testnet.go
@@ -85,7 +85,7 @@ func addTestnetFlagsToCmd(cmd *cobra.Command) {
 	cmd.Flags().String(flags.FlagKeyType, string(hd.Secp256k1Type), "Key signing algorithm to generate keys for")
 
 	// support old flags name for backwards compatibility
-	cmd.Flags().SetNormalizeFunc(func(f *pflag.FlagSet, name string) pflag.NormalizedName {
+	cmd.Flags().SetNormalizeFunc(func(_ *pflag.FlagSet, name string) pflag.NormalizedName {
 		if name == "algo" {
 			name = flags.FlagKeyType
 		}

diff --git a/x/auction/client/cli/query.go b/x/auction/client/cli/query.go
@@ -34,7 +34,7 @@ func CmdQueryParams() *cobra.Command {
 		Use:   "params",
 		Short: "Query the current parameters of the auction module",
 		Args:  cobra.NoArgs,
-		RunE: func(cmd *cobra.Command, args []string) error {
+		RunE: func(cmd *cobra.Command, _ []string) error {
 			clientCtx, err := client.GetClientQueryContext(cmd)
 			if err != nil {
 				return err