Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(use-focus): adds focusWithin flag to useFocus hook #164

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dvcol
Copy link

@dvcol dvcol commented Jan 15, 2025

When creating a component wrapper, it is often useful to broaden the focus trigger to include any focused element within.

For example if my component includes a focusable input within a styled container, I might want to trigger the floating element on container hover or on input focus (e.g. tab navigation).

<script lang="ts">
import {
  useFloating,
  useFocus,
  useHover,
  useInteractions,
} from "@skeletonlabs/floating-ui-svelte";

const floating = useFloating({ focusWithin: true });
const focus = useFocus(floating.context);
const hover = useHover(floating.context);
const interactions = useInteractions([focus, hover]);
</script>

<!-- Reference Element -->
<div bind:this={floating.elements.reference} {...interactions.getReferenceProps()}>
  <label>My Label</label>
  <input placeholder="Type something here" />
</div>

<!-- Floating Element -->
<div
  bind:this={floating.elements.floating}
  style={floating.floatingStyles}
  {...interactions.getFloatingProps()}
>
  Floating
</div>

Copy link

changeset-bot bot commented Jan 15, 2025

⚠️ No Changeset found

Latest commit: a2414a4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
floating-ui-svelte ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 8:21am

This adds an option to add onfocusin and onfocusout event handlers to the focus hook.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant