Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSS being removed by tree shaking in Webpack #31

Closed
wants to merge 14 commits into from

Conversation

JJCLane
Copy link
Contributor

@JJCLane JJCLane commented Apr 12, 2020

When running a build for production, the CSS from the vue-password component was removed. This fixes #30.

@skegel13
Copy link
Owner

@JJCLane I will take a look at this, hopefully later today. I see you keep adding commits, let me know when you have it how you think it should be.

@JJCLane
Copy link
Contributor Author

JJCLane commented Apr 13, 2020

@skegel13 Should be in a good shape now 👍 Sorry I realise it was just pulling everything from my master branch, but I also fixed a bug where the password field was automatically being focused on page load which fixes #25.

@skegel13
Copy link
Owner

@JJCLane Can you break this up into multiple PRs, one for the css changes and one for the focus changes?

@JJCLane
Copy link
Contributor Author

JJCLane commented Apr 14, 2020

Done! I'll close this in favour of #32 and #33. Thanks @skegel13

@JJCLane JJCLane closed this Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

为什么样式在部署环境没有引入的问题
2 participants