1545 second half - DRAFT - DONT REVIEW YET! #2075
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SUGGESTIONS BEFORE MERGE:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rewrote Unddos and stats implementation with a way simpler one since the previous one had lots of bugs and deadlocks.
The new Unddos impelementation does not use any locks and can not cause a deadlock.
Made sure that tracing calls are only enabled when tracing is enabled, previously tracing was affecting performance even if disabled.
When forming a block proposal from the pending queue, If two transactions have the same gas price and height related to the current nonce, we currently give priority to the older transaction. Previously the behavior was undefined, so old transactions could stay in the pending queue for a long time.
Tests
Describe how you tested the changes made in this pull request. Include specific tests you have added. Replace this comment with your testing methodology.
Performance Impact
Describe any potential impact on performance due to your changes. Include any benchmarks you performed, if applicable, and compare the results with and without your changes. Replace this comment with your performance analysis.