Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning in builtin.go.h #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fdanis-oss
Copy link

@fdanis-oss fdanis-oss commented Apr 17, 2019

When building go-debos/debos with latest glib-2.0 I've got the following warnings multiple times:

# github.com/sjoerdsimons/ostree-go/pkg/otbuiltin
In file included from /usr/include/glib-2.0/glib/glist.h:32,
from /usr/include/glib-2.0/glib/ghash.h:33,
from /usr/include/glib-2.0/glib.h:50,
from ../../../../sjoerdsimons/ostree-go/pkg/otbuiltin/builtin.go:16:
../../../../sjoerdsimons/ostree-go/pkg/otbuiltin/builtin.go.h: In function '_g_clear_object':
/usr/include/glib-2.0/glib/gmem.h:121:18: warning: passing argument 1 of 'g_object_unref' discards 'volatile' qualifier from pointer target type [-Wdiscarded-qualifiers]
(destroy) (_ptr); \
^~~~
/usr/include/glib-2.0/gobject/gobject.h:672:36: note: in expansion of macro 'g_clear_pointer'
#define g_clear_object(object_ptr) g_clear_pointer ((object_ptr), g_object_unref)
^~~~~~~~~~~~~~~
../../../../sjoerdsimons/ostree-go/pkg/otbuiltin/builtin.go.h:51:3: note: in expansion of macro 'g_clear_object'
g_clear_object(object_ptr);
^~~~~~~~~~~~~~
In file included from /usr/include/glib-2.0/gobject/gbinding.h:29,
from /usr/include/glib-2.0/glib-object.h:23,
from /usr/include/glib-2.0/gio/gioenums.h:28,
from /usr/include/glib-2.0/gio/giotypes.h:28,
from /usr/include/glib-2.0/gio/gio.h:26,
from /usr/include/ostree-1/ostree-types.h:26,
from /usr/include/ostree-1/ostree-async-progress.h:24,
from /usr/include/ostree-1/ostree.h:24,
from ../../../../sjoerdsimons/ostree-go/pkg/otbuiltin/builtin.go:17:
/usr/include/glib-2.0/gobject/gobject.h:494:64: note: expected 'gpointer' {aka 'void *'} but argument is of type 'volatile GObject *' {aka 'volatile struct _GObject *'}
void g_object_unref (gpointer object);
~~~~~~~~~~~~~~~~^~~~~~

Since glib-2-58 g_clear_object takes a non-volatile GObject** (cf. GNOME/glib@2aacef3 )

Signed-off-by: Frédéric Danis [email protected]

When building go-debos/debos with latest glib-2.0 I've got the following
warnings multiple times:

# github.com/sjoerdsimons/ostree-go/pkg/otbuiltin
In file included from /usr/include/glib-2.0/glib/glist.h:32,
from /usr/include/glib-2.0/glib/ghash.h:33,
from /usr/include/glib-2.0/glib.h:50,
from ../../../../sjoerdsimons/ostree-go/pkg/otbuiltin/builtin.go:16:
../../../../sjoerdsimons/ostree-go/pkg/otbuiltin/builtin.go.h: In function '_g_clear_object':
/usr/include/glib-2.0/glib/gmem.h:121:18: warning: passing argument 1 of 'g_object_unref' discards 'volatile' qualifier from pointer target type [-Wdiscarded-qualifiers]
(destroy) (_ptr); \
^~~~
/usr/include/glib-2.0/gobject/gobject.h:672:36: note: in expansion of macro 'g_clear_pointer'
#define g_clear_object(object_ptr) g_clear_pointer ((object_ptr), g_object_unref)
^~~~~~~~~~~~~~~
../../../../sjoerdsimons/ostree-go/pkg/otbuiltin/builtin.go.h:51:3: note: in expansion of macro 'g_clear_object'
g_clear_object(object_ptr);
^~~~~~~~~~~~~~
In file included from /usr/include/glib-2.0/gobject/gbinding.h:29,
from /usr/include/glib-2.0/glib-object.h:23,
from /usr/include/glib-2.0/gio/gioenums.h:28,
from /usr/include/glib-2.0/gio/giotypes.h:28,
from /usr/include/glib-2.0/gio/gio.h:26,
from /usr/include/ostree-1/ostree-types.h:26,
from /usr/include/ostree-1/ostree-async-progress.h:24,
from /usr/include/ostree-1/ostree.h:24,
from ../../../../sjoerdsimons/ostree-go/pkg/otbuiltin/builtin.go:17:
/usr/include/glib-2.0/gobject/gobject.h:494:64: note: expected 'gpointer' {aka 'void *'} but argument is of type 'volatile GObject *' {aka 'volatile struct _GObject *'}
void g_object_unref (gpointer object);
~~~~~~~~~~~~~~~~^~~~~~

Since glib-2-58 g_clear_object takes a non-volatile GObject** (cf.
GNOME/glib@2aacef3 )

Signed-off-by: Frédéric Danis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant