-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added meet the Helm #2
base: master
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis pull request introduces a new "Meet the Helm" component to showcase the Business Club IIT (BHU) team members. It displays their names, roles, descriptions, and images in a visually appealing grid layout. The component fetches member data and renders it dynamically, allowing for easy updates and additions to the team roster. Class diagram for MeetTheHelm componentclassDiagram
class MeetTheHelm {
+members: Member[]
+render(): JSX
}
class Member {
+name: string
+role: string
+description: string
+image: ImageSource
}
MeetTheHelm "1" *-- "*" Member : contains
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tanmay-s18 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider removing the commented-out JSX code to keep the codebase clean.
- Image files should follow a consistent naming convention (e.g., 'astha-shetty-profile.jpg') instead of using screenshots and timestamps.
Here's what I looked at during the review
- 🟡 General issues: 3 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
src/components/meetHelm.tsx
Outdated
@@ -0,0 +1,82 @@ | |||
import React from 'react'; | |||
|
|||
import image1 from '../assets/images/Screenshot 2024-12-24 225656.png'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Use semantic names for image assets
Screenshot timestamps as image names are not maintainable. Consider using descriptive names that reflect the content (e.g., 'astha_profile.png').
Suggested implementation:
import asthaImage from '../assets/images/astha_secretary_profile.png';
import memberTwoImage from '../assets/images/member_two_profile.jpeg';
import memberThreeImage from '../assets/images/member_three_profile.png';
image: asthaImage,
You will need to:
- Rename the actual image files in the assets directory to match the new import paths:
- Rename "Screenshot 2024-12-24 225656.png" to "astha_secretary_profile.png"
- Rename "1723468189219.jpeg" to "member_two_profile.jpeg"
- Rename "Screenshot 2024-12-24 225827.png" to "member_three_profile.png"
- Update any other references to image2 and image3 in the component (which are not visible in the provided code snippet) to use memberTwoImage and memberThreeImage respectively
@tanmay-s18 , Attach the preview , fix tailwind , rename images as suggested . Also add tailwind by @apply directive wherever required (check rasesh's PR) |
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Vite.React.-.Google.Chrome.2024-12-28.16-39-06.mp4 |
Vite.React.TS.-.Google.Chrome.2025-01-07.00-51-51.1.mp4 |
Summary by Sourcery
New Features: