Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added meet the Helm #2

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

tanmay-s18
Copy link
Contributor

@tanmay-s18 tanmay-s18 commented Dec 26, 2024

Summary by Sourcery

New Features:

  • Display the Business Club IIT (BHU) team members with their names, roles, descriptions, and images.

Copy link

sourcery-ai bot commented Dec 26, 2024

Reviewer's Guide by Sourcery

This pull request introduces a new "Meet the Helm" component to showcase the Business Club IIT (BHU) team members. It displays their names, roles, descriptions, and images in a visually appealing grid layout. The component fetches member data and renders it dynamically, allowing for easy updates and additions to the team roster.

Class diagram for MeetTheHelm component

classDiagram
    class MeetTheHelm {
        +members: Member[]
        +render(): JSX
    }

    class Member {
        +name: string
        +role: string
        +description: string
        +image: ImageSource
    }

    MeetTheHelm "1" *-- "*" Member : contains
Loading

File-Level Changes

Change Details Files
Created the MeetTheHelm component
  • Implemented the UI structure with a responsive grid layout for displaying team members.
  • Added image assets for each member.
  • Included placeholders for social media links.
  • Fetched and displayed member data dynamically.
  • Styled the component with appropriate colors, fonts, and spacing to ensure visual appeal and readability on different screen sizes.
src/components/meetHelm.tsx

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tanmay-s18 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider removing the commented-out JSX code to keep the codebase clean.
  • Image files should follow a consistent naming convention (e.g., 'astha-shetty-profile.jpg') instead of using screenshots and timestamps.
Here's what I looked at during the review
  • 🟡 General issues: 3 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

src/components/meetHelm.tsx Outdated Show resolved Hide resolved
src/components/meetHelm.tsx Outdated Show resolved Hide resolved
@@ -0,0 +1,82 @@
import React from 'react';

import image1 from '../assets/images/Screenshot 2024-12-24 225656.png';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Use semantic names for image assets

Screenshot timestamps as image names are not maintainable. Consider using descriptive names that reflect the content (e.g., 'astha_profile.png').

Suggested implementation:

import asthaImage from '../assets/images/astha_secretary_profile.png';
import memberTwoImage from '../assets/images/member_two_profile.jpeg';
import memberThreeImage from '../assets/images/member_three_profile.png';
            image: asthaImage,

You will need to:

  1. Rename the actual image files in the assets directory to match the new import paths:
    • Rename "Screenshot 2024-12-24 225656.png" to "astha_secretary_profile.png"
    • Rename "1723468189219.jpeg" to "member_two_profile.jpeg"
    • Rename "Screenshot 2024-12-24 225827.png" to "member_three_profile.png"
  2. Update any other references to image2 and image3 in the component (which are not visible in the provided code snippet) to use memberTwoImage and memberThreeImage respectively

@sivangbagri
Copy link
Owner

@tanmay-s18 , Attach the preview , fix tailwind , rename images as suggested . Also add tailwind by @apply directive wherever required (check rasesh's PR)

tanmay-s18 and others added 3 commits December 28, 2024 15:57
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
@tanmay-s18
Copy link
Contributor Author

Vite.React.-.Google.Chrome.2024-12-28.16-39-06.mp4

@tanmay-s18
Copy link
Contributor Author

Vite.React.TS.-.Google.Chrome.2025-01-07.00-51-51.1.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants