Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#13 added active tab feature in navbar #16

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

tanmay-s18
Copy link
Contributor

@tanmay-s18 tanmay-s18 commented Jan 31, 2025

Vite.React.TS.-.Google.Chrome.2025-01-31.18-20-41.mp4

Summary by Sourcery

New Features:

  • Highlight the active tab in the navigation bar based on the current route.

Copy link

sourcery-ai bot commented Jan 31, 2025

Reviewer's Guide by Sourcery

This pull request implements an active tab feature in the navbar. The active tab is highlighted with a bold font and an underline. The implementation uses react-router-dom's useLocation hook to determine the current path and conditionally apply the active class to the corresponding link.

Sequence diagram for navbar active tab behavior

sequenceDiagram
    participant U as User
    participant N as Navbar
    participant R as Router
    participant L as useLocation Hook

    U->>N: Clicks navigation link
    N->>R: Navigate to new route
    N->>L: Get current location
    L-->>N: Return pathname
    N->>N: Compare pathname with link paths
    N->>N: Apply active styles to matching link
    N-->>U: Display updated navbar with active tab
Loading

Class diagram for navbar component changes

classDiagram
    class Navbar {
        -location: Location
        +render()
    }
    class Link {
        +to: string
        +className: string
    }
    class Router {
    }
    class useLocation {
        +pathname: string
    }
    Navbar --> Link : uses
    Navbar --> useLocation : uses
    Navbar --> Router : wrapped by
    note for Navbar "Now uses React Router components
and tracks active state"
Loading

File-Level Changes

Change Details Files
Implemented active tab highlighting in the navbar.
  • Added react-router-dom's useLocation hook to determine the current path.
  • Added conditional styling to the nav-link class to highlight the active tab.
  • Modified the navbar links to use react-router-dom's Link component instead of anchor tags.
src/components/Navbar.tsx
src/styles/navbar.css
Modified the App component to include the Navbar inside the Router component.
  • Moved the Navbar component inside the Router component to enable the use of react-router-dom's useLocation hook.
src/App.tsx

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

vercel bot commented Jan 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
biz-web-24 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 0:58am

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tanmay-s18 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@tanmay-s18 tanmay-s18 changed the title #14 added active tab feature in navbar #13 added active tab feature in navbar Jan 31, 2025
@sivangbagri
Copy link
Owner

#13

@sivangbagri sivangbagri merged commit fbe6232 into sivangbagri:master Feb 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants