Skip to content

Commit

Permalink
fix: added missing target="_blank"
Browse files Browse the repository at this point in the history
  • Loading branch information
kevin0216 committed Nov 23, 2024
1 parent 322239d commit 81d5051
Show file tree
Hide file tree
Showing 7 changed files with 45 additions and 10 deletions.
1 change: 1 addition & 0 deletions app/cfp/(submission)/_components/countdown.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ export default function CountdownPage() {
</div>
<div className="h-full w-[40%] rounded-2xl bg-foreground transition-all duration-[0.4s] hover:bg-primary">
<Link
target="_blank"
className="flex h-full w-full items-center justify-center"
href={"/cfp/deadline.ics"}
>
Expand Down
21 changes: 14 additions & 7 deletions app/cfp/(submission)/normal/page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,7 @@ export default function Page() {
<p>
歡迎寄信至{" "}
<Link
target="_blank"
href="mailto:[email protected]"
className="cursor-pointer text-primary underline"
>
Expand Down Expand Up @@ -270,7 +271,11 @@ export default function Page() {
.toReversed()
.map((year, index) => (
<span key={year}>
<Link className="link" href={`https://sitcon.org/${year}`}>
<Link
target="_blank"
className="link"
href={`https://sitcon.org/${year}`}
>
{year}
</Link>
{<span>{index == 10 ? "" : "、"}</span>}
Expand Down Expand Up @@ -327,8 +332,8 @@ export default function Page() {
投稿格式
</h2>
<p className="leading-10">
Presentation 與
Espresso的投稿格式相同,除標示為公開之資訊會對外公布外,其餘僅供審稿委員於審稿時閱讀。
Presentation 與 Espresso
的投稿格式相同,除標示為公開之資訊會對外公布外,其餘僅供審稿委員於審稿時閱讀。
</p>
<h3 className="my-4 text-h3-mobile font-bold text-primary md:text-h3">
稿件資訊
Expand All @@ -341,10 +346,7 @@ export default function Page() {
請不要超出<span className="subTitle hightlight"> 20 </span>
字,題目無須與年會主題相關。
</InformationField>
<InformationField
title="摘要 Abstract:"
tags={["required", "public"]}
>
<InformationField title="摘要 Abstract" tags={["required", "public"]}>
<span className="hightlight subTitle"> 150~250 </span>
字,使用於宣傳與網站公告。
</InformationField>
Expand Down Expand Up @@ -490,6 +492,7 @@ export default function Page() {
<p className="text-normal-mobile font-normal leading-10 tracking-wider md:text-normal">
若有任何問題或投稿建議,請來信 SITCON 議程組信箱{" "}
<Link
target="_blank"
href="mailto:[email protected]"
className="cursor-pointer text-primary underline"
>
Expand All @@ -510,6 +513,7 @@ export default function Page() {
<p className="text-normal-mobile font-normal leading-10 tracking-wider md:text-normal">
今年將採取實體與線上同步之模式進行,除開放式議程外,年會當天將對每一場議程進行直播串流。如果您同意以
<Link
target="_blank"
href={"https://creativecommons.org/licenses/by/4.0/deed.zh-hant"}
className="hightlight subTitle underline underline-offset-2"
>
Expand All @@ -518,6 +522,7 @@ export default function Page() {
</Link>
授權釋出議程錄影,我們將會上傳至
<Link
target="_blank"
href={"https://sitcon.org/yt"}
className="hightlight subTitle underline underline-offset-2"
>
Expand All @@ -526,6 +531,7 @@ export default function Page() {
</Link>
<Link
target="_blank"
href={"https://odysee.com/@SITCON:f"}
className="hightlight subTitle underline underline-offset-2"
>
Expand All @@ -538,6 +544,7 @@ export default function Page() {
您為議程準備的其餘相關素材(如投影片),將於年會前由 SITCON
議程組向您蒐集素材連結,並整理在年會官方網站的議程資訊上。您可以自行決定在何種平台、以何種方式釋出,我們不會干涉,但鼓勵您選擇允許知識共享的
<Link
target="_blank"
href={"https://creativecommons.org/licenses/by/4.0/deed.zh-hant"}
className="hightlight subTitle underline underline-offset-2"
>
Expand Down
4 changes: 4 additions & 0 deletions app/cfp/(submission)/poster/page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -306,6 +306,7 @@ export default function Page() {
<p className="text-normal-mobile font-normal leading-10 tracking-wider md:text-normal">
今年將採取實體與線上同步之模式進行,除開放式議程外,年會當天將對每一場議程進行直播串流。如果您同意以
<Link
target="_blank"
href={"https://creativecommons.org/licenses/by/4.0/deed.zh-hant"}
className="hightlight subTitle underline underline-offset-2"
>
Expand All @@ -314,6 +315,7 @@ export default function Page() {
</Link>
授權釋出議程錄影,我們將會上傳至
<Link
target="_blank"
href={"https://sitcon.org/yt"}
className="hightlight subTitle underline underline-offset-2"
>
Expand All @@ -322,6 +324,7 @@ export default function Page() {
</Link>
<Link
target="_blank"
href={"https://odysee.com/@SITCON:f"}
className="hightlight subTitle underline underline-offset-2"
>
Expand All @@ -334,6 +337,7 @@ export default function Page() {
您為議程準備的其餘相關素材(如投影片),將於年會前由 SITCON
議程組向您蒐集素材連結,並整理在年會官方網站的議程資訊上。您可以自行決定在何種平台、以何種方式釋出,我們不會干涉,但鼓勵您選擇允許知識共享的
<Link
target="_blank"
href={"https://creativecommons.org/licenses/by/4.0/deed.zh-hant"}
className="hightlight subTitle underline underline-offset-2"
>
Expand Down
4 changes: 4 additions & 0 deletions app/cfp/(submission)/undefined/page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,7 @@ export default function Page() {
<p className="text-normal-mobile font-normal leading-10 tracking-wider md:text-normal">
今年將採取實體與線上同步之模式進行,除開放式議程外,年會當天將對每一場議程進行直播串流。如果您同意以
<Link
target="_blank"
href={"https://creativecommons.org/licenses/by/4.0/deed.zh-hant"}
className="hightlight subTitle underline underline-offset-2"
>
Expand All @@ -324,6 +325,7 @@ export default function Page() {
</Link>
授權釋出議程錄影,我們將會上傳至
<Link
target="_blank"
href={"https://sitcon.org/yt"}
className="hightlight subTitle underline underline-offset-2"
>
Expand All @@ -332,6 +334,7 @@ export default function Page() {
</Link>
<Link
target="_blank"
href={"https://odysee.com/@SITCON:f"}
className="hightlight subTitle underline underline-offset-2"
>
Expand All @@ -344,6 +347,7 @@ export default function Page() {
您為議程準備的其餘相關素材(如投影片),將於年會前由 SITCON
議程組向您蒐集素材連結,並整理在年會官方網站的議程資訊上。您可以自行決定在何種平台、以何種方式釋出,我們不會干涉,但鼓勵您選擇允許知識共享的
<Link
target="_blank"
href={"https://creativecommons.org/licenses/by/4.0/deed.zh-hant"}
className="hightlight subTitle underline underline-offset-2"
>
Expand Down
1 change: 1 addition & 0 deletions app/cfp/_components/code-of-conduct.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ export default function CodeOfConduct() {
歡迎不同身分、來自不同背景的與會者,我們鼓勵女性、性少數與多元背景的參與者。為了讓大家都能愉快地參加
SITCON,我們要求所有參與者閱讀年會的{" "}
<Link
target="_blank"
href={"https://sitcon.org/code-of-conduct/"}
className="text-primary underline underline-offset-2"
>
Expand Down
21 changes: 18 additions & 3 deletions app/cfp/_components/footer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ function Links() {
{ text: "開放式議程投稿", href: "/cfp/undefined" },
{ text: "海報投稿", href: "/cfp/poster" },
]}
internal
/>
);
}
Expand All @@ -71,6 +72,7 @@ function Support() {
// { text: "我要贊助", href: "https://sitcon.org/donate" },
{ text: "索取贊助徵求書", href: "https://i.sitcon.org/2025cfs-form/" },
]}
internal={false}
/>
);
}
Expand Down Expand Up @@ -103,6 +105,7 @@ function Contact() {
links={[
{ text: "[email protected]", href: "mailto:[email protected]" },
]}
internal={false}
/>
);
}
Expand Down Expand Up @@ -153,15 +156,27 @@ interface LinkText {
href: string;
}

function FooterSubMenu({ title, links }: { title: string; links: LinkText[] }) {
function FooterSubMenu({
title,
links,
internal,
}: {
title: string;
links: LinkText[];
internal: boolean;
}) {
return (
<ul className="flex flex-col gap-2">
<li className="mb-2 font-bold">{title}</li>
{links.map((link) => {
const { text, href } = link;
return (
<li key={href}>
<Link className="hover:opacity-70" href={href}>
<Link
target={internal ? "" : "_blank"}
className="hover:opacity-70"
href={href}
>
{text}
</Link>
</li>
Expand All @@ -186,7 +201,7 @@ function FooterSubMenuGrid({
const { text, href } = link;
return (
<li key={href}>
<Link className="hover:opacity-70" href={href}>
<Link target="_blank" className="hover:opacity-70" href={href}>
{text}
</Link>
</li>
Expand Down
3 changes: 3 additions & 0 deletions app/cfp/page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ export default function Home() {
</Link>
</div>
<Link
target="_blank"
href="/cfp/deadline.ics"
className="w-auto rounded-[50px] bg-[#FFFFFF] px-8 py-1 text-center transition hover:bg-foreground max-sm:w-full"
>
Expand Down Expand Up @@ -112,12 +113,14 @@ export default function Home() {
</p>
<div className="flex gap-6 pt-14 max-[1024px]:grid max-[1024px]:grid-cols-8 max-[1024px]:gap-5 max-sm:grid-cols-2">
<Link
target="_blank"
href="https://groups.google.com/g/sitcon-general/"
className="w-[140px] rounded-[50px] bg-secondary py-3 text-center font-bold transition hover:bg-foreground max-[1024px]:col-span-5 max-[1024px]:w-auto max-[1024px]:rounded-lg max-[1024px]:text-[18px] max-[712px]:my-auto max-[712px]:text-[14px] max-sm:col-span-1 max-sm:rounded-[72px] max-sm:text-[18px] max-sm:font-normal"
>
訂閱郵件論壇
</Link>
<Link
target="_blank"
href="https://gitlab.com/sitcon-tw/2025/board/-/boards"
className="w-[140px] rounded-[50px] bg-secondary py-3 text-center font-bold transition hover:bg-foreground max-[1024px]:col-span-3 max-[1024px]:w-auto max-[1024px]:rounded-lg max-[1024px]:text-[18px] max-[712px]:my-auto max-[712px]:text-[14px] max-sm:col-span-1 max-sm:rounded-[72px] max-sm:text-[18px] max-sm:font-normal"
>
Expand Down

0 comments on commit 81d5051

Please sign in to comment.