2D unstructured converter, nonlinear discretizations and improvements to multimodel #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
moyner
commented
Aug 28, 2024
•
moyner
commented
- Nonlinear finite volume schemes (@moyner)
- Improvements to plotting (@moyner, @hnil)
- Extra hooks for battery controls (@xavierr)
- MultiModel labels and concrete types (@xavierr, @moyner)
- Some other small fixes and usability improvements
Add option to make multi model immutable
Should clean up dict vs JutulStorage confusion
Extend mesh support for 2D and Cartesian converters
…xes (#88) * Add NFVM submodule + tests * Use function form for NFVM * Use norm for checking reconstruction * NFVM: Support both vectors and matrices * Put tpfa flux in function * Unify coefficient calculations * NFVM: Rename triplet -> basis * NFVM: Don't use optional argument for phase * Add option to not throw in get_variable for missing var * Add test * NFVM: Check input argument "scheme" * NFVM: Better error message for decomposition failure * NFVM: Better handling for failures in decomposition * NFVM: Clean up NTPFA code * Update triplets.jl * Sign and weight subscript fix to NTPFA * Speed up NFVM flux * Update flux.jl * Add dispatch for storage when using fvm * Update flux.jl * Some WIP work on FVM asm * Update fvm_assembly.jl * Finish FVM alignment * Update fvm_assembly.jl * Update fvm_assembly.jl * Implement equation update for FVM * First draft of FVM assembly * FVM-assembly: Fix to sparsity * FVM: Correct sign * Simplify FVM assembly a bit * Fixed last bug in FVM assembly (?) * Speed up FVM assembly * Some minor performance improvements * Inbounds in new flux * Add some comments * NFVM: Move inbounds into inner functions * Add subdiscretization for potential flow * Update decomposition.jl * Factor out storage into constructor * Update conservation.jl * Update conservation.jl
Battmo supporting features in sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.