Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/add retry #82

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Test/add retry #82

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
6781d86
first attempt at retry logic
HarrisonMarcRose Aug 10, 2021
b67845c
refactor check and verify, make sure tests use the sync with backoff …
HarrisonMarcRose Aug 10, 2021
5c1af3c
fix mistake
HarrisonMarcRose Aug 11, 2021
521fb0d
fix check on failure for retry
HarrisonMarcRose Aug 11, 2021
4bff44d
typo
HarrisonMarcRose Aug 11, 2021
4c3402e
get current state and set it on retry of tap
HarrisonMarcRose Aug 11, 2021
06ac3db
add retry for discovery errors
HarrisonMarcRose Aug 11, 2021
7014a7f
fix typo
HarrisonMarcRose Aug 11, 2021
4a51010
fix typo
HarrisonMarcRose Aug 11, 2021
d171263
fix typo
HarrisonMarcRose Aug 11, 2021
0d6cf34
Merge branch 'master' into test/add-retry
HarrisonMarcRose Aug 23, 2021
bab6dd4
try one more time
HarrisonMarcRose Aug 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ def create_connection(self, original_properties: bool = True):

@backoff.on_exception(backoff_wait_times,
RetryableTapError,
max_tries=3)
max_tries=4)
def run_check_mode(self, conn_id):
# Run a check job using orchestrator (discovery)
check_job_name = runner.run_check_mode(self, conn_id)
Expand Down Expand Up @@ -249,7 +249,7 @@ def run_and_verify_check_mode(self, conn_id):

@backoff.on_exception(backoff_wait_times,
RetryableTapError,
max_tries=3)
max_tries=4)
def run_and_verify_sync(self, conn_id, state):
"""
Run a sync job and make sure it exited properly.
Expand Down