core: introduce patch data classes and crude parser upgrade beginnings #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinewavey
commented
Apr 26, 2024
| @@ -79,7 +84,7 @@ func build_gamepack_text() -> String: | |||
| if sound_type != sound_types[-1]: | |||
| soundtypes_str += " " | |||
|
|
|||
| var gamepack_text: String = """<?xml version="1.0"?> | |||
| var gamepack_text: String = """<?xm000l version="1.0"?> | |||
sinewavey
commented
Apr 26, 2024
| @@ -133,3 +133,13 @@ class FuncGodotTextureData: | |||
|
|
|||
| func _init(in_name: String): | |||
| name = in_name | |||
|
|
|||
| class FuncGodotPatchVertex: | |||
There was a problem hiding this comment.
this doesn't feel like a great solution, but for now and simplicity's sake, I'm treating patches as special objects, though in the map file proper they are part of brush defs.
sinewavey
commented
Apr 26, 2024
| 0: current_patch.texture_idx = map_data.register_texture(buf_str) | ||
| 1,2: current_patch.indices[component_idx - 1] = float(buf_str) | ||
| 3,4,5: pass # Contains face attributes, which are currently unsupported in func_godot | ||
|
|
There was a problem hiding this comment.
Still needs the rest of the vertices to be read
sinewavey
commented
Apr 26, 2024
| @@ -286,13 +349,20 @@ func commit_face() -> void: | |||
| current_brush.faces.append(current_face) | |||
| current_face = FuncGodotMapData.FuncGodotFace.new() | |||
|
|
|||
| func commit_patch() -> void: | |||
|
|
|||
There was a problem hiding this comment.
if this overall split is kept, the current_patch = patch.new() call should happen here instead of where it's currently happening
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a few changes to prepare for integrating Quake 3's quadratic Bezier patches: updating the token parser and scope.
Part 1 of at least 2.