Preprocessing #13
Closed
Preprocessing #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I took the liberty of reformatting the comments slightly to match the preferred line length in Rust. Feel free to revert the commit (or just delete it and force-push) if you'd rather keep the previous formatting. |
fkettelhoit
approved these changes
Apr 15, 2024
src/faand.rs
Outdated
|
|
||
| // Assign objects to buckets | ||
| let mut available: Vec<usize> = (0..length).collect(); | ||
| let mut shared_rng = shared_rng(&mut channel, p_own, p_max).await?; |
There was a problem hiding this comment.
I know that we don't want to focus too much on performance optimizations at this stage, but perhaps it makes sense to reuse the shared_rng from the fabitn fn?
There was a problem hiding this comment.
This was a visible improvement right away, thanks!
|
We can close this one, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.