Update MQTT3 pack connect

simps · Jan 14, 2021 · e669288 · e669288
1 parent 9d908b7
commit e669288
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/src/Hex/ReasonCode.php b/src/Hex/ReasonCode.php
@@ -173,7 +173,7 @@ public static function getReasonPhrases(bool $isQos = false): array
     public static function getReasonPhrase(int $value, bool $isQos = false): string
     {
         if ($isQos) {
-            return static::$qosReasonPhrases[$value] ?? 'Wrong QoS';
+            return static::$qosReasonPhrases[$value] ?? 'QoS not supported';
         }
 
         return static::$reasonPhrases[$value] ?? 'Unknown';

diff --git a/src/Packet/Pack.php b/src/Packet/Pack.php
@@ -13,6 +13,8 @@
 
 namespace Simps\MQTT\Packet;
 
+use Simps\MQTT\Exception\ProtocolException;
+use Simps\MQTT\ProtocolInterface;
 use Simps\MQTT\Tools\PackTool;
 use Simps\MQTT\Types;
 
@@ -28,6 +30,9 @@ public static function connect(array $array): string
         if (!empty($array['will'])) {
             $connectFlags |= 1 << 2;
             if (isset($array['will']['qos'])) {
+                if ($array['will']['qos'] > ProtocolInterface::MQTT_QOS_2) {
+                    throw new ProtocolException("QoS {$array['will']['qos']} not supported");
+                }
                 $connectFlags |= $array['will']['qos'] << 3;
             }
             if (!empty($array['will']['retain'])) {

diff --git a/src/ProtocolInterface.php b/src/ProtocolInterface.php
@@ -25,6 +25,12 @@ interface ProtocolInterface
 
     const MQTT_PROTOCOL_NAME = 'MQTT';
 
+    const MQTT_QOS_0 = 0;
+
+    const MQTT_QOS_1 = 1;
+
+    const MQTT_QOS_2 = 2;
+
     public static function pack(array $array): string;
 
     public static function unpack(string $data): array;