Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argument for having episodes in a directory with their respective season name #49

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

AlexIsOK
Copy link
Contributor

@AlexIsOK AlexIsOK commented May 18, 2020

This will allow users to download series separated by season names.

Example:

//with --folderBySeason

anime
    Season1
        Episode1 of Season1
        Episode2 of Season1
        Episode3 of Season1
    Season2
        Episode1 of Season2
        Episode2 of Season2
        Episode3 of Season2

//without --folderBySeason
anime
    Episode1 of Season1
    Episode1 of Season2
    Episode2 of Season1
    Episode2 of Season2
    Episode3 of Season1
    Episode3 of Season2

This should not mess with anything, but I will allow edits in case something is wrong.

Edit: I have also included a tool to move anime that already exist to the new folder (for people that are using this tool for automation)

@simplymemes
Copy link
Owner

Can we use the path lib for any path creation? I believe that windows does not support forward slashes in their paths

@AlexIsOK
Copy link
Contributor Author

@simplymemes Right, I forgot Windows uses \ instead of /. I'll change this to use path instead of fs.rename()

@AlexIsOK
Copy link
Contributor Author

AlexIsOK commented May 29, 2020

May take a bit longer than expected, I needed to make a Windows VM to run this on, but I should have a fix within the next two hours.

Edit: due to the bug listed in #50 I will not be able to test this on my Windows VM. I'll implement the feature when the bug is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants