Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding ADC calibration for STM32F1.
Before:
RAM: [= ] 9.0% (used 4444 bytes from 49152 bytes)
Flash: [=== ] 26.6% (used 69712 bytes from 262144 bytes)
offset_ia = 1.574506
offset_ib = 1.566360
After:
RAM: [= ] 9.0% (used 4444 bytes from 49152 bytes)
Flash: [=== ] 26.8% (used 70208 bytes from 262144 bytes)
offset_ia = 1.630240
offset_ib = 1.623240
Slightly increases memory usage because of the use of an additional hal function, but should make all the adc measurements closer to reality.
The only risk I see are: