Ability to block domains when receiving emails #2344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tozo
requested review from
acasajus,
cquintana92 and
nguyenkims
as code owners
tozo
changed the title
tozo
changed the title
|
@acasajus, @cquintana92, @nguyenkims Could one of you take a look at this PR at some point and let me know if you have any questions or if anything needs to be changed? I know it's holiday season, so it can take time, just wanted to make sure this PR is not overlooked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the functionality to block domains so that the user won't receive emails no matter which email was used on that domain.
It's mainly to prevent spam emails coming from the same domain but from different email addresses.
Since this feature is not tied to a specific alias/custom domain I added it to the setting page.
Let me know if there is a better place for this feature or if anything else needs to be changed.
Note: This feature was discussed here: #1344 .
Couple of screenshots:
Default view
Page once domains are blocked:
