-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/#1111 #1117
Open
NishantKumar-2005
wants to merge
3
commits into
simplcommerce:master
Choose a base branch
from
NishantKumar-2005:fix/#1111
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix/#1111 #1117
NishantKumar-2005
wants to merge
3
commits into
simplcommerce:master
from
NishantKumar-2005:fix/#1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The transaction is started using _dbContext.Database.BeginTransaction(). The product is queried and locked for update using ForUpdate(). The stock quantity is checked and updated within the transaction. The transaction is committed after the order is created. This ensures that the stock check and update are performed atomically, preventing race conditions.
The transaction is started using _dbContext.Database.BeginTransaction(). The product is queried and locked for update using saveChanges(). The stock quantity is checked and updated within the transaction. The transaction is committed after the order is created. This ensures that the stock check and update are performed atomically, preventing race conditions.
The transaction is started using _dbContext.Database.BeginTransaction(). The product is queried and locked for update using saveChanges(). The stock quantity is checked and updated within the transaction. The transaction is committed after the order is created. This ensures that the stock check and update are performed atomically, preventing race conditions.
I don't know why the License Compliance Failed I did not use any Dependency in Code |
Don't worry about it for now |
Why you closed the PR? |
Due to no response , I reopened it |
@NishantKumar-2005 please format your code @AbdullahAlmutawa please your review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this code:
Fixes/#1111
The transaction is started using _checkoutItemRepository.BeginTransaction().
The product is queried and locked for update using _checkoutItemRepository.saveChanges().
The stock quantity is checked and updated within the transaction.
The transaction is committed after the order is created.
This ensures that the stock check and update are performed atomically, preventing race conditions.