User registration email not validated #720 #1068
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please resolve the conflicts |
afernandes
reviewed
Jan 29, 2024
| @@ -14,8 +14,8 @@ public class EmailSender : IEmailSender | |||
| public EmailSender(IConfiguration config) | |||
| { | |||
| _emailConfig.SmtpServer = config.GetValue<string>("SmtpServer"); | |||
| _emailConfig.SmtpUsername = config.GetValue<string>("SmtpUsername"); | |||
| _emailConfig.SmtpPassword = config.GetValue<string>("SmtpPassword"); | |||
| _emailConfig.SmtpUsername = "[email protected]"; | |||
There was a problem hiding this comment.
It is not recommended to use a fixed email.
The email must be configurable.
afernandes
suggested changes
Jan 29, 2024
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "ConnectionStrings": { | |||
| "DefaultConnection": "Server=.;Database=SimplCommerce;Trusted_Connection=True;TrustServerCertificate=true;MultipleActiveResultSets=true" | |||
| "DefaultConnection": "server=DotNetFSD\\SQLEXPRESS;database = SimplCommerce;user id = sa; password = pass@123;trustservercertificate = true;MultipleActiveResultSets=true" | |||
|
Closed while there's no respond from the author Feel free to reopen the PR again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User after registering with an Email gets the verification link to his Mailbox. By clicking on the verification link he/she will be redirected to the verifying page and from there user can go to login after the successful verification. Used a sample email and app specific password to generate emails to the registered user.
Email Id : [email protected]
Password : Welcome@123
App Specific Password : mecv erfk mosu fvji
Modified Files :
-- src/Modules/SimplCommerce.Module.Core/Areas/Core/Controllers/AccountController.cs
-- src/Modules/SimplCommerce.Module.EmailSenderSmtp/EmailSender.cs