Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

59 app tile #64

Merged
merged 9 commits into from
Mar 16, 2024
Merged

59 app tile #64

merged 9 commits into from
Mar 16, 2024

Conversation

FearsomeRover
Copy link
Contributor

I added the konf app tile, and replaced the counter with it. I know, it wont be used for a while.
magyar
angol
I think the english buttons look way better.

Copy link

vercel bot commented Mar 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
konf-web-2024 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 16, 2024 1:18pm

@FearsomeRover FearsomeRover changed the base branch from main to dev March 1, 2024 18:02
Copy link
Member

@Tschonti Tschonti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The google image behaves differently than the apple one. Is there no svg version of the google image?
image

I agree that the English buttons look better, but everything else is in Hungarian, so I think we should stick with that.

Also, it'd be great if we could include the questions in the text. What do you think about this:
Töltsd le a mobil appot, hogy élőben köveshesd a konferencia eseményeit és kérdezhess az előadóktól!

Copy link
Member

@Tschonti Tschonti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
There's no gap between the images on small screens, and the scaling is still a bit weird. I think the appStore should be below the google on small screens, that should solve these problems

Tschonti
Tschonti previously approved these changes Mar 2, 2024
Copy link
Member

@Tschonti Tschonti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, but let's not merge it until the app is released!

Base automatically changed from dev to main March 4, 2024 09:49
@Tschonti Tschonti dismissed their stale review March 4, 2024 09:49

The base branch was changed.

@Tschonti Tschonti changed the base branch from main to dev March 4, 2024 09:51
Base automatically changed from dev to main March 4, 2024 16:28
@Tschonti
Copy link
Member

Tschonti commented Mar 4, 2024

öööö az utolsó commit biztos ide akart jönni?

@Tschonti Tschonti changed the base branch from main to dev March 4, 2024 23:21
Base automatically changed from dev to main March 4, 2024 23:22
@Tschonti
Copy link
Member

Tschonti commented Mar 6, 2024

ooopsiee, shouldn't have done that xd

I'll fix it once it's ready to merge

@Tschonti Tschonti changed the base branch from main to dev March 16, 2024 13:13
@Tschonti Tschonti merged commit 7f6202c into dev Mar 16, 2024
3 of 4 checks passed
@Tschonti Tschonti deleted the 59-app-tile branch March 16, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants