added the option to return the full waveform #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gured but no DAQ ist started and no readout is attempted.
…applied on neighbors to seed pixels.
Caribou apts
AD: Fixed `ts_i` reset condition.
…mps instead of trigger ids.
…d of trigger ids.
Caribou apts
Caribou dsipm
|
This needs updating since we have waveform support in StandardPlane now. @lhuth I'll leave this down for reference anyway, feel free to use this PR for updates. |
Caribou lab
|
Aye - I'll take care of it later (or tomorrow) |
|
63 changed files? Seems odd. Could you make sure to use my latest caribou branch and add towards that? |
|
I assumed that this will change after you update your branch :) I'll check again... |
|
🚀 |
|
|
Autoformatting was mindblowing :)... Readme is updated... |
simonspa
reviewed
Aug 10, 2022
| * `threshold_low`: Threshold in ADC counts to add to a cluster with a seed hit with a charge above `threshold_trig`. Defaults to 101 | ||
| * `use_time_stamp`: Defines if a time stamp is added to the event. Defaults to `false` | ||
| * "use_waveform": Copy the full waveform with a pixel hit. If set, `threshold_trig` and `threshold_low` are ignored. Defaults to `false` | ||
| * `wavefrom_filename`: Name of a potential file to txt dump the waveforms. Defaultts to "". |
There was a problem hiding this comment.
wavefrom_filename -> waveform_filename
Defaultts -> Defaultts
Add that waveform files are only written if filename is not empty.
There was a problem hiding this comment.
and single backticks around use_waveform
simonspa
force-pushed
the
caribou
branch
2 times, most recently
from
bccd51c to
f7b6f9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, this is a hacky approach to reading the full waveform to corry. On the longer term I'd like to improve this... but for now it works as long as one configures the EventLoaderEUDAQ2 correctly. Compare https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/535