Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap tags into aman; use source list to find sources in tags #868

Merged
merged 2 commits into from
May 22, 2024
Merged

Wrap tags into aman; use source list to find sources in tags #868

merged 2 commits into from
May 22, 2024

Conversation

davidvng
Copy link
Contributor

  • Wrap tags into aman in preprocess_tod instead of changing config file
  • Corresponding changes in SourceFlags to extract source from the tags list
  • Set global catalog of sources that can be imported using from sotodlib.coords.planets import SOURCE_LIST
  • Added 'moon' to this source list as moon obs were failing for SSOFootprint

@davidvng davidvng requested a review from msilvafe May 21, 2024 20:20
msilvafe
msilvafe approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@msilvafe msilvafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good, thanks!

sotodlib/coords/planets.py Show resolved Hide resolved
sotodlib/preprocess/processes.py Show resolved Hide resolved
@davidvng davidvng merged commit 3d2c666 into master May 22, 2024
5 checks passed
@davidvng davidvng deleted the preprocess-tags branch May 22, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msilvafe msilvafe msilvafe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidvng @msilvafe