Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HkDb: sort paths before loading frames #1106

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

HkDb: sort paths before loading frames #1106

wants to merge 1 commit into from

Conversation

jlashner
Copy link
Contributor

Resolves #1105.

@jlashner jlashner requested a review from mhasself January 23, 2025 23:15
mhasself
mhasself approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@mhasself mhasself left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely the quickest solution. Unfortunate that it imposes a sorting condition on the filenames in the database.

There are alternatives, but not simple ones...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhasself mhasself mhasself approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HkDb: Frames can be loaded in the wrong order
2 participants
@jlashner @mhasself