Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify error message when there is a detector count mismatch #1088

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Clarify error message when there is a detector count mismatch #1088

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce5738c
Clarify error message when there is a detector count mismatch
jlashner Jan 8, 2025
651b31b
change det mismatch error to Matthew's suggestion
jlashner Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sotodlib/core/metadata/loader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -637,7 +637,9 @@ def merge_det_info(det_info, new_info, multi=True, on_missing='trim'):
f'in the det_id, maybe add {k} to the match_keys?')

if len(det_info) != len(i1) and on_missing != 'trim':
raise IncompleteMetadataError('{len(det_info)} -> {len(i1)})')
raise IncompleteMetadataError(
f"det_info had n_dets={len(det_info)}; After merge it has n_dets={len(i1)}"
)

logger.debug(f' ... updating det_info (row count '
f'{len(det_info)} -> {len(i1)})')
Expand Down
Loading