Add try except to catch det_match failures #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to incorporate updates to file cleanup in the demod mapmaking functions. |
msilvafe
approved these changes
Jan 3, 2025
Comment on lines
304
to
305
| policy_dir_init = os.path.dirname(configs_init['archive']['policy']['filename']) + '/temp/' | ||
| policy_dir_proc = os.path.dirname(configs_proc['archive']['policy']['filename']) + '/temp_proc/' |
There was a problem hiding this comment.
Let's use os.path.join() instead of + str
Comment on lines
308
to
321
| if os.path.exists(policy_dir_init): | ||
| found = False | ||
| for f in os.listdir(policy_dir_init): | ||
| if obs_id in f: | ||
| found = True | ||
| break | ||
|
|
||
| if found: | ||
| error = pp_util.save_group_and_cleanup(obs_id, configs_init, context_init, | ||
| subdir='temp', remove=overwrite) | ||
| if error is not None: | ||
| f = open(errlog, 'a') | ||
| f.write(f'\n{time.time()}, cleanup error\n{error[0]}\n{error[2]}\n') | ||
| f.close() |
There was a problem hiding this comment.
Can this whole block be a single function that takes in policy_dir, obs_id, config, context, subdir, remove, and errlog so we can just call that line twice here (and in other places where its needed i.e. preprocess_tod, demod mapmaker)
| obs_id = obs['obs_id'] | ||
| pp_util.save_group_and_cleanup(obs_id, configs, context, | ||
| subdir='temp', remove=overwrite) | ||
| policy_dir = os.path.dirname(configs['archive']['policy']['filename']) + '/temp/' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some error checking around
preprocess_utils.get_groupsto catch failures related to getting det info.